Repository navigation
Conversation
The platform takes fileExtension from the multipart filename. A Blob passed to createFile or updateFile was appended without one, so it went up as "blob" and the item was stored with fileExtension "", which Automation extension conditions never match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #71.
createFilewraps a bareBlobin aFilenamed after the item (new File([blob], name, { type: blob.type })), so the multipart upload carries the name and the platform setsfileExtensionfrom it. AFilekeeps its own name.updateFiledoes the same whennameis given; without a name the upload is unchanged.createComponent,createApp, versions) are untouched, since their uploads are bundles.files.tsexample: a comment on the Blob upload; patch changeset.Tests: three cases in
client.test.ts("upload filename"): a bare Blob goes up asresult.jsonwith its content intact, aFilekeepsmodel.ifc, andupdateFilenames a Blob. The two Blob cases fail on main (expected 'blob' to be 'result.json').yarn lint,tsc --noEmitandvitest runpass (154 tests). I didn't run thefiles.tsexample against the live API.