Repository navigation
Update & Pin GHA deps - #1492
Merged
Merged
Conversation
ulgens
marked this pull request as draft
September 24, 2026 07:30
Fixes https://docs.zizmor.sh/audits/#unpinned-uses and increases supply chain security
Resolves > Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24... warnings and updates the dependencies. This operation can be automated via renovate: https://docs.renovatebot.com/modules/manager/github-actions/
ulgens
force-pushed
the
update-gha-deps
branch
from
September 24, 2026 13:41
ee1d7a0 to
efdc79b
Compare
ulgens
marked this pull request as ready for review
September 24, 2026 13:54
ilyamandel
approved these changes
Oct 25, 2026
ilyamandel
left a comment
ilyamandel
left a comment
Collaborator
There was a problem hiding this comment.
Sorry for the long silence, @ulgens , I was secretly hoping that someone with more GitHub workflow knowledge than me (@avivajpeyi ? @reinhold-willcox ?) might review these; but happy to trust you!
Collaborator
|
At first I was a bit surprised by the pinning of particular commit hashes rather than version tags but I've read around and it appears this is becoming standard practice, even though I'd actually never seen it before. All the major projects I had a quick look at (e.g. NumPy, requests, LLVM) use this idiom and it appears that dependabot supports it. I've checked that the hashes correspond to the listed versions, so I personally think this is good to merge but I'm also not a core dev. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves deprecation warnings, improves supply chain security and an overall cleaning & update operation.
Can be automated via renovate: https://docs.renovatebot.com/modules/manager/github-actions/