Skip to content

Updates to debugging_utils - #1487

Open
reinhold-willcox wants to merge 2 commits into
devfrom
update_to_debugging_utils
Open

reinhold-willcox wants to merge 2 commits into
devfrom
update_to_debugging_utils

Conversation

@reinhold-willcox

Copy link
Copy Markdown
Collaborator

The get_event_strings function (and the related subfunctions) now allow for an optional seeds argument to be passed. Previously, these functions would only operate on the entire COMPAS dataset, which can become quite slow for large datasets.

There is also some minor tidying to the module.

@ilyamandel ilyamandel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @reinhold-willcox . I am not a regular python user, but happy to approve since nobody else is jumping in. :)

@reinhold-willcox

Copy link
Copy Markdown
Collaborator Author

Thanks Ilya! There's something going wrong in the pychecks though, I'll fix that first.

@ilyamandel

Copy link
Copy Markdown
Collaborator

Hi @reinhold-willcox , @avivajpeyi

Any luck in fixing the pytests? I am happy for you to pull this in, regardless.


=========================== short test summary info ============================
FAILED py_tests/test_debugging_utils.py::test_get_event_history_and_event_strings - TypeError: object of type 'numpy.int64' has no len()
= 1 failed, 50 passed, 1 skipped, 1 deselected, 7 warnings in 62.21s (0:01:02) =
Error: Process completed with exit code 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants