Repository navigation
New compas debugging_utils file - #1467
Conversation
Print final velocity components
Enhancements- deprecated MERRITT2024 in favour of , plus others
…ies of distribution
…nd --muller-mandel-sigma-kick-BH
03.22.00: fixes to nuclear timescale mass transfer, new 2-stage CE options, etc: Changed default values of --enhance-CHE-lifetimes-luminosities and --scale-CHE-mass-loss-with-surface-helium-abundance to true Added options to set beta and gamma prescription for second stage of 2-stage CE (--common-envelope-second-stage-beta, --common-envelope-second-stage-gamma-prescription) Fixed a bug in CalculateZetaEquilibrium(), which impacted when mass transfer is declared nuclear (and how conservative it is) Now calculate mass accretion rate for nuclear timescale mass transfer on the fly to match with donor mass loss rate set by donor mass loss (required to fit into Roche lobe) divided by time step Fixed random draws of SN kicks to avoid artificial pile-up at boundaries of distribution Split --muller-mandel-sigma-kick into --muller-mandel-sigma-kick-NS and --muller-mandel-sigma-kick-BH
Fixed random kick draw for MULLERMANDEL prescription
Fix for whats-new page
Update docker image construction
|
@ilyamandel @nrsegovia No idea why the other files were showing up here, the identical local branches for me were showing the correct file diffs. In the end, changing the base branch to something else then changing it back to dev seems to have solved it, so this looks like a weird github quirk/bug. @ilyamandel I'm happy to add some documentation. Also, I'm still iterating with @avivajpeyi on the best way to implement unit tests for this section of the code. |
|
Hey @reinhold-willcox how do these look for unit tests? |
avivajpeyi
left a comment
avivajpeyi
left a comment
There was a problem hiding this comment.
Looks good! You could add some automated markdown docs in the future if you'd like
ilyamandel
left a comment
ilyamandel
left a comment
There was a problem hiding this comment.
Thanks, @reinhold-willcox !
The only thing preventing me from changing "Changes requested" to "Approved" is the documentation. ;-)
2-detector selection effects in Matlab post-processing
reinhold-willcox
changed the title
|
@ilyamandel I've added in the documentation, by cleaning up the notebook for post-processing demos. I actually wrote this notebook ages ago on the same functions, but now it's cleaner and works with the updated syntax. @avivajpeyi I'm happy with your unit tests. If we decide we need more, we can create some. Note that there are now a large number of commits. This is because I accidentally added a file that was too large for github, and had to do some fancy git command to remove it. This shouldn't have an impact on the repo though, since you can see that only 6 files are changed. |
ilyamandel
left a comment
ilyamandel
left a comment
There was a problem hiding this comment.
I was wondering if you wanted to add a pointer directly to https://compas.readthedocs.io/en/latest/pages/User%20guide/Post-processing/post-processing.html -- but happy to approve.
|
@ilyamandel I don't follow. That pages already points to the Basic COMPAS Data Analysis notebook. Unless I'm misunderstanding you? |
|
@reinhold-willcox : all good, I hadn't appreciated that DataAnalysis.py would take the place of DataAnalysis.html. |
Added my own compasUtils file, which I use for lots of post-processing and testing. It was previously in
misc/unsupported_utils, so I am hoping to get it elevated to the level of the other utils.This contains two major functions that help a lot with inspecting COMPAS data.
I expect that there will be changes requested, so it is probably not yet ready to be merged in, but happy to hear feedback on how to improve / align these scripts with the other python utilities.