Repository navigation
Move To / coordinates dialogs: drop the title rule, name the real workspace, M on MCS - #9
Merged
Merged
Conversation
The list now starts directly below the title like the other dialogs, and the dialog is one row shorter. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The Move To and Move to position dialogs built their label as "WCS{slot}", a leftover from
when slots were just WCS1-WCS10. 34477c2 introduced the slot names (User (RML-1), EXOFS,
WCS1 (G54)...) but only switched the header over, so slot 1 showed as "WCS1" rather than
"User (RML-1)" and G54 (slot 3) as "WCS3". Both titles now use wcs_label() like the header.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
shuckc
force-pushed
the
move-to-dialog
branch
from
November 9, 2026 10:19
1c88032 to
dc664c9
Compare
The handler returned early for MCS ("MCS origin is always (0,0,0,0) — no-op / already there"),
since the first version of the dialog. The MCS origin is the machine zero, but the tool is not
necessarily there, so the move is real. MCS already has (0,0,0,0) loaded in index 0, so removing
the special case sends the normal absolute move. The overwrite keys still refuse MCS.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
shuckc
changed the title
shuckc
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small fixes to the move-related dialogs.
Changes
WCS{slot}, a leftover from when slots were justWCS1–WCS10. 34477c2 introduced the real names (User (RML-1),EXOFS,WCS1 (G54)…) but only switched the header over, so slot 1 showed as "WCS1" and G54 (slot 3) as "WCS3". Both titles now usewcs_label()like the header.Mon MCS in the coordinates dialog now moves to machine 0,0,0,0. The handler returned early for MCS ("MCS origin is always (0,0,0,0) — no-op / already there"), since the first version of the dialog. The MCS origin is the machine zero, but the tool is not necessarily there, so the move is real. MCS already had(0,0,0,0)loaded, so removing the special case sends the normal bracketed absolute move (SET 0x04f7, 1800 mm/min). The overwrite keys still refuse MCS. Like the other stored-origin moves, X, Y and Z travel together.Test plan
pytest -q: 160 passed, 1 skippedtests/test_wcs_titles.pydrives both dialogs through a fake curses window for slots 0–8 and checks the exact title text (9 of its 10 Move To cases fail without the fix)tests/test_wcs_dialog_move.py:Mon MCS sends the move to machine zero, is bracketed like other moves,Mon a stored origin still moves to it, and the overwrite keys still refuse MCS (the two MCS move tests fail without the fix)ruff checkon both new test filesMon MCS on the real machine, and look at the dialogs on a real terminal🤖 Generated with Claude Code