Skip to content

fix: check skill examples in TypeScript 7 repositories - #308

Merged
LadyBluenotes merged 1 commit into
mainfrom
fix/typescript-7-compiler-api
Oct 3, 2026
Merged

LadyBluenotes merged 1 commit into
mainfrom
fix/typescript-7-compiler-api

Conversation

@LadyBluenotes

Copy link
Copy Markdown
Member

🎯 Changes

  • intent validate, intent repair, and maintainer review summaries crashed in repositories that use TypeScript 7 with Cannot read properties of undefined (reading 'ESNext'). The TypeScript 7 typescript package exports only version fields, so the 5.0 minimum version check passed and the example checker then read a compiler API that is not there.
  • Examples are now checked through the compiler API that TypeScript 7 publishes under typescript/unstable/*, loaded from the repository, so a TypeScript 7.0 repository gets the same example checks as a TypeScript 6 repository with nothing extra to install. The async API is used, so this also works under Bun.
  • When @typescript/typescript6 is installed beside TypeScript 7, that package is used instead.
  • When neither API can run, example checks are skipped with a reason and the other checks still run. validate reports Skill code blocks were not typechecked: ..., and repair reports the reason as a problem.
  • Both compiler paths share one set of compiler options in tsconfig form. checkSkillBlocks, planExampleRepairs, describeSkillExamples, and runRepairCommand are now async.
  • Adds typescript7, an alias of typescript@7.0.2, as a devDependency of packages/intent. The alias links TypeScript 7's tsc into the package, so test:types runs the workspace TypeScript 6 by path.
  • Docs: TypeScript 7.0 support, Node.js 24 or newer, and TypeScript 7.1 is not supported at this time.
  • Adds a patch changeset.

Fixes #307

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr (run pnpm build:all first).

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

@changeset-bot

changeset-bot Bot commented Oct 3, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 10bc21b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tanstack/intent Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: dec31c7f-965a-4bba-92a4-1e9833964ec0
📥 Commits

Reviewing files that changed from the base of the PR and between 796fd6a and 10bc21b.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (11)
  • .changeset/typescript-7-compiler-api.md
  • docs/cli/intent-repair.md
  • docs/cli/intent-validate.md
  • packages/intent/package.json
  • packages/intent/src/cli.ts
  • packages/intent/src/commands/maintainer.ts
  • packages/intent/src/commands/repair.ts
  • packages/intent/src/commands/validate.ts
  • packages/intent/src/validate/blocks.ts
  • packages/intent/tests/repair.test.ts
  • packages/intent/tests/validate-blocks.test.ts
 __________________________________________________________________________
< Mirror, mirror on the wall, who's the best AI code reviewer of them all? >
 --------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 10bc21b

Command Status Duration Result
nx affected --targets=test:eslint,test:sherif,t... ✅ Succeeded 55s View ↗
nx run-many --targets=build ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2026-10-03 15:59:25 UTC

@pkg-pr-new

pkg-pr-new Bot commented Oct 3, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@tanstack/intent@308

commit: 10bc21b

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedtypescript@​7.0.29910089100100

View full report

@LadyBluenotes
LadyBluenotes merged commit 9e4a28d into main Oct 3, 2026
8 of 9 checks passed
@LadyBluenotes
LadyBluenotes deleted the fix/typescript-7-compiler-api branch October 3, 2026 16:00
@codspeed

codspeed Bot commented Oct 3, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 12 untouched benchmarks


Comparing fix/typescript-7-compiler-api (10bc21b) with main (796fd6a)

Open in CodSpeed

@github-actions github-actions Bot mentioned this pull request Oct 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression: intent validate crashes with TypeScript 7 after upgrading from 0.4.0 to 0.5.x

1 participant