fix: check skill examples in TypeScript 7 repositories - #308
Conversation
🦋 Changeset detectedLatest commit: 10bc21b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (11)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 10bc21b
☁️ Nx Cloud last updated this comment at |
commit: |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
🎯 Changes
intent validate,intent repair, and maintainer review summaries crashed in repositories that use TypeScript 7 withCannot read properties of undefined (reading 'ESNext'). The TypeScript 7typescriptpackage exports only version fields, so the 5.0 minimum version check passed and the example checker then read a compiler API that is not there.typescript/unstable/*, loaded from the repository, so a TypeScript 7.0 repository gets the same example checks as a TypeScript 6 repository with nothing extra to install. The async API is used, so this also works under Bun.@typescript/typescript6is installed beside TypeScript 7, that package is used instead.validatereportsSkill code blocks were not typechecked: ..., andrepairreports the reason as a problem.checkSkillBlocks,planExampleRepairs,describeSkillExamples, andrunRepairCommandare now async.typescript7, an alias oftypescript@7.0.2, as a devDependency ofpackages/intent. The alias links TypeScript 7'stscinto the package, sotest:typesruns the workspace TypeScript 6 by path.Fixes #307
✅ Checklist
pnpm run test:pr(runpnpm build:allfirst).🚀 Release Impact