Repository navigation
feat: usurp an overlord through a movement, and preview war goals before the code - #198
Merged
Merged
Conversation
…ore the code A vassal no longer declares a usurp war on its own overlord. It starts a Usurp movement in the overlord's government instead: only direct vassal leaders who could take the title may lead it, the overlord can cave in, and otherwise it becomes a civil war with the Usurp goal. Winning lets the cause leader's faction take the overlord's highest title. The declare war button now opens the goal picker straight away. Leaders can see every available goal and what it wins (reparations at today's income, pillage loot per settlement, subject effects, usurped title and subjects) before asking staff for a code. The code is asked for when they confirm, and the confirmation reopens once it is accepted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 20 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
the
size:L
Usurping makes the old overlord the usurper's subject and hands over its subjects. A usurper whose laws forbid vassals took the title but left the old overlord independent and kept its subjects in place, found while testing on Dev. The movement, the war goal and its validator now require a vassalage law. The default Usurp action carries its description for servers whose political-actions.yml predates it, and the usurp preview line no longer loses a space in the client. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Usurp by a vassal is now a movement. A vassal can no longer declare a Usurp war on its own overlord (the goal is hidden, and the validator says to start a movement instead). Instead there is a new
usurppolitical action:CivilWarGoalMapper).FactionManager.usurp. If the leader is gone, the first eligible faction in the cause takes it.WarOutcomeServicesends a Usurp war with a movement id through the movement, so the civil war untangle restores vassalage first.FactionManager.usurphanded over the title but left the old overlord independent and its subjects in place (found on Dev).political-actions.ymlgets ausurpentry. The loader adds a vassal-only default if a server's copy predates it, so live configs work without editing.Browse war goals before the staff code. The declare war button now opens the goal picker straight away, even when a code is required. The code is asked for when the leader confirms, and the confirmation reopens once the code is accepted. The menus now show what each goal wins:
Test plan
mvn verifylocally (only the two known local-only failures); jacoco shows no new fully-missed lines.UsurpMovementTest,WarGoalPreviewTest; updated declare/validator/outcome/prompt tests.usurptied to the movement; attacker victory → The Sanctuary holds the duchy, The Holy Order is its subject, and Sporetopia moved under it.🤖 Generated with Claude Code