Repository navigation
Conversation
|
What's the point of this PR? |
|
There's a bunch of issue with this, not least of which is I want to ship the C files so that cython is not required to install this module... |
|
Thanks for the feedback, I'll close this. For the record, the point was: pip builds from source fails On Cython: pip fetches it automatically through build-system.requires, so users Happy to revisit a narrower version if there's interest. |
|
Sorry, I'm not against your PR, I just didn't understand it. so the main motivation is install from the source code should be able to build against TA-Lib static C library , like the wheels do? |
|
Yes. When installing from source, the build currently needs TA-Lib C installed first. With this Nothing changes if a suitable TA-Lib is already installed (version >= TALIB_C_VER) |
|
I'm considering a version of this change. While I test it, are there platforms or architectures or versions of Python that we don't have support for that is motivating this change for you? |
|
Right now, a source install fails if there is no system TA-Lib C, or if the With this change, a source install builds TA-Lib C statically when no suitable The wheels were already self-contained, so nothing changes for wheel users. I Honestly, my main motivation is testing with ThreadSanitizer, and this is what |
Changes
setup.py):TA_GetVersionString) is >=TALIB_C_VER.talib._ta_lib..pyxonly: cythonization now happens insidebuild_ext, andinclude talib/*.cis removed fromMANIFEST.in.test-dev.ymlbuilds CdevthroughTALIB_C_URL.TA_TSAN=1builds the extension and a static TA-Lib C with ThreadSanitizer.make test-tsanruns the threading tests.tsan.ymlruns the suite on free-threaded 3.14t and 3.15t using prebuilt TSAN images.