Repository navigation
fix: isolate compiler passes during runtime recompilation - #10
Merged
Merged
Conversation
Signed-off-by: Brian Schäffner <burnify.design@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kernel rebuilds a candidate container when compilation discovers additional
resources. Compiler passes were reused across candidates, so stateful native
passes could update Definition objects retained from the discarded container.
Doctrine event listeners then disappeared from the final runtime container.
Clone each compiler-pass prototype for every candidate build. Pass order and
the original application builder remain unchanged. Add a regression that forces
resource discovery, checks isolated pass state, and reloads the cached container.
Validation:
composer qapassed (78 tests, 372 assertions; seven existing PHPUnitnotices and one environment-dependent skip). The consuming Doctrine bundle's
SQLite integration suite passed, including real listener invocation, Messenger,
Maker generation and a fresh-process cached-container reload.