Repository navigation
ArteCheck: support Subtitle Edit Batch convert - #323
Merged
Merged
Conversation
PluginBootstrap.Run takes an optional batch handler; a "batch" request (Subtitle Edit Batch convert) is answered without starting Avalonia. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- plugin.json "batch": true - batch request: apply every correction, re-check up to 5 passes, no UI - configure request: settings-only window; also saves Timed-for frame rate and programme start for batch runs (normal runs keep and ignore them) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds batch convert support to ARTE check. This uses the plugin batch contract from SubtitleEdit/subtitleedit#16036.
plugin.json:"batch": true.batchrequest: no UI. Every correction is applied, re-checking up to 5 passes because one fix can make room for another. Alarms are counted in the message but not fixed.configurerequest: the window opens with no subtitle and shows a "Batch convert settings" panel; OK returns only the settings. Configure also saves Timed for (frame rate) and the programme start, under separatebatch*keys. A normal run ignores these keys but keeps them when it saves settings.PluginBootstrap.Runtakes an optional batch handler, so abatchrequest is answered without starting Avalonia. Also addsPluginRequestTypeconstants. The same commit is in the Fix encoding errors PR, so whichever PR merges second merges cleanly.Tests:
BatchModeTests(5 tests); 100 ArteCheck tests pass.Not tested inside real SE yet; needs SE with #16036.
🤖 Generated with Claude Code