Run native ST build on arm64 host when using docker - #298
Merged
Merged
Conversation
Member
|
May those changes also be relevant for actions/setup ? |
deathaxe
reviewed
Sep 26, 2026
deathaxe
pushed a commit
that referenced
this pull request
Sep 26, 2026
Follow up to PR #298 - make `sublime-text-arch` optional and auto-detect arch if not provided - install arch-matching build of ST - test ARM variant in CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker by default starts native docker image (on arm64 system it runs arm64 linux image) but the install_sublime_text script had hardcoded download of a x64 ST build which either ran very slowly or completely failed (for example latest ubuntu fails on mac arm when running under Rosetta).
Default to arm64 build of ST when running under arm host.