Repository navigation
Pin the Python 3.8 CI job to ubuntu-22.04 and stop fail-fast - #28
Merged
Merged
Conversation
ubuntu-latest now resolves to Ubuntu 26.04, for which setup-python publishes no 3.8 build, so every Build run failed at install and fail-fast cancelled 3.10 and 3.12. The 3.8 entry now runs on ubuntu-22.04, the others stay on ubuntu-latest, and the job keeps its test (<python>) name so check names do not change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review of head Rubric:
Judgment calls flagged for the owner:
Merge: This review was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test (3.8)entry of theBuildmatrix is pinned toubuntu-22.04.ubuntu-latestnow resolves to Ubuntu 26.04, andactions/setup-python@v5publishes no 3.8 build for that image, so every run failed at install (The version '3.8' with architecture 'x64' was not found for Ubuntu 26.04).3.10and3.12stay onubuntu-latest.fail-fast: falseis set, so an interpreter that cannot be installed no longer cancels the other two jobs and leaves the run with no signal.test (${{ matrix.python }}), so the check names staytest (3.8),test (3.10)andtest (3.12), the same as before. Any required-check configuration onmainkeeps matching.requires-pythonis unchanged.Closes #26
ubuntu-22.04is the first option listed in #26. Branch protection could not be inspected from this session, which is why the job name is kept stable.Test plan
python3 -m unittestlocally on Python 3.8.10:Ran 67 tests ... OK. No client or test code is changed.Buildon this PR:test (3.8)installs Python 3.8 onubuntu-22.04and passes, andtest (3.10)andtest (3.12)pass onubuntu-latest. This PR's own CI run is the evidence that the fix works.Notes
.github/workflows/*is on the dev loop's do-not-auto-merge list, so this PR is left for the owner to merge.Buildruns should go green on a re-run once this is merged and they are updated withmain, although both still need the three missing version bumps described in their reviews.MAX_TAGScap and a matching change in trace-client-java.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson