Repository navigation
Document what the wire format drops: NaN/infinite values, None tags and blank names - #24
Merged
Merged
Conversation
…nd blank names Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…he event out Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (head 999871a, CI run 40076138281):
Finding fixed during review:
Docs-only change, verified against source and green CI; ready to merge. This review comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage A documentation accuracy sweep. The README's "The wire format" section and the
report()docstring were checked against_json,_with_versionandreport(); three behaviors the code has (each already covered by a test) were undocumented:valueis omitted not only when absent but also when NaN or ±infinity (_json;test_json_drops_nan_and_none_tags,test_json_drops_infinite_values_but_keeps_zero).Noneis left out, and other keys/values are sent as strings (_with_version,_json).nameis not sent at all (report();test_report_ignores_a_blank_name).The rest of the sweep (promises table, "Turning it off", constructor/install-ID docs, module headers,
pyproject.toml, "Building" vs.build.yml) found no drift.No code behavior changed; the only edit to
trace_client/trace_client.pyis thereport()docstring. No Java-visible behavior changed, so trace-client-java needs no matching change.Test plan
python3 -m unittest: ran 67 tests, OK, locallyBuildgreen on 3.8 / 3.10 / 3.12No tracking issue: the gap was found during triage. #16 was skipped again because it still waits on an owner decision about the
MAX_TAGScap and needs a coordinated trace-client-java change. The README sentence "tagsalways holds at leastversion" was left as is for that reason.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson