Add NeuroExplorerSortingExtractor - #4825
Open
h-mayorquin wants to merge 1 commit into
Open
h-mayorquin wants to merge 1 commit into
h-mayorquin wants to merge 1 commit into
Conversation
h-mayorquin
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a sorting extractor for NeuroExplorer, for which we already have a recording extractor.
One problem is that python-neo exposes both neuron variables and waveform variables as spike channels, and in Plexon exports every unit comes with a
_wfvariable holding the same spike train with snippets and a_templatevariable holding its mean waveform as a single spike. Reading all of them as units would duplicate every neuron, so only the neuron variables (the spike channels without waveforms) become units. I kept the filtering local and override the index mapping so each unit still reads its own spike channel.Doing this made realize there are some problems with the python-neo reader. I will tackle that separately.