Drop the separate core test workflow - #4822
Open
h-mayorquin wants to merge 1 commit into
Open
h-mayorquin wants to merge 1 commit into
h-mayorquin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
core-test.ymlruns the core tests on the three OSes with Python 3.10, butall-tests.ymlalready does the same as its first test step (same events, same--group test-coreinstall, plus Python 3.13) and stops the job before the expensive modules if core fails. This PR removescore-test.ymlso every push to a PR runs three fewer jobs, and runs the core step ofall-tests.ymlthroughrun_tests.shso we keep the verbose output and the timing summary.This is the last item of #3100 that I think is worth doing, so this should close #3100.