Repository navigation
Bump SparseDiffEngine to main (sparsediff_linalg 0.4.0 nested submodule) - #30
Merged
Merged
Conversation
…bmodule) The engine now carries its sparse linear algebra as a git submodule, sparsediff_linalg (pinned to v0.4.0 in this engine commit). A recursive clone or `git submodule update --init --recursive` brings it in; the sdist built by scikit-build-core includes the nested files (verified: the tarball contains SparseDiffEngine/sparsediff_linalg with its CMakeLists, headers and sources, and a wheel builds from that tarball alone). Also drops the stale SparseDiffEngine/include/utils include directory, which has not existed since the library split. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the engine pin from
06481d9(0.8.0 dev start) to currentmain(c1e7e43, "Update to sparsediff_linalg 0.4.0"). Since the library split, the engine carries its sparse linear algebra as a nested git submodule,SparseDiffEngine/sparsediff_linalg, pinned to a tag (v0.4.0 here). Nothing in the bindings changes: they include only engine headers, and those include only the four library headers that still exist (CSR_matrix.h,CSC_matrix.h,COO_matrix.h,matrix.h).Also drops the stale
SparseDiffEngine/include/utilsinclude directory fromCMakeLists.txt; it has not existed since the split.What this PR verifies, which had been an open claim since the split:
git ls-files --recurse-submodulessees the nested library files (33 sources), so scikit-build-core's sdist includes them. A locally builtsparsediffpy-0.8.0.tar.gzcontainsSparseDiffEngine/sparsediff_linalg/with itsCMakeLists.txt, headers and sources.conda.recipe/test_sparsediffpy.py. This is the path conda-forge takes.Note for the conda-forge recipe (staged-recipes #34978, still open): its
0001-use-conda-forge-blas.patchedits BLAS discovery and/WXinSparseDiffEngine/CMakeLists.txt. Both moved: BLAS discovery now lives inSparseDiffEngine/sparsediff_linalg/CMakeLists.txtand already handles conda-forge's split libcblas and config-less OpenBLAS, and the engine already turns/WXoff underSKBUILD. When the recipe is updated to the next release the patch should be dropped rather than re-pointed; this repo'sconda-recipe.ymlCI builds without it.Workflows (
build-and-publish.yml,conda-recipe.yml) already check out submodules recursively, which now covers the nested one.🤖 Generated with Claude Code