Repository navigation
Bump sparsediff_linalg to v0.6.0 - #170
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR pins
sparsediff_linalgto v0.6.0, up from v0.5.1. No engine source change: the engine calls the matmul dispatchers only (BTA_matrices_*,ATDA_matrices_*,BA_kron_*,sum_n_matrices_*), and none of the changed or removed symbols appear outsidenotes/.It takes in library PRs #34–#38:
BA_dense_kron_matrices_*/BA_sparse_kron_matrices_*made private (the engine usesBA_kron_matrices_*since #167)B @ S), then 4 rows of B per visited entry inBA_pd_csr_fill_valuesB^T AandA^T AB Aandkron(I_p, A) Jon the Gustavson core; the dot-form kernels droppedPublic API changes in the library, none of which the engine calls directly:
BTA_allocnow takes(CSR A, CSC B);BTDA_fill_valuesgained adouble *accargument;csr_csc_matmul_*andblock_left_multiply_fill_*were removed.Testing
-Wcast-qualwarnings, all inside the library.git grepfinds no engine references to the changed or removed symbols outsidenotes/.🤖 Generated with Claude Code