Repository navigation
Add Windows ARM64 native build support - #443
Merged
Merged
Conversation
Add a windowsarm64 target to generateLibs using the LLVM-MinGW clang wrappers, with a shared createWindowsTarget() helper keeping the existing x86_64 path intact. LLVM-MinGW builds against libc++, which does not pull <exception> transitively, so patch imgui-node-editor's crude_json.cpp through the existing vendor patch flow. Bundle the LWJGL natives-windows-arm64 classifiers in imgui-app and document the direct Gradle build path. Co-authored-by: DeepSeek <noreply@deepseek.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
windowsarm64native build target togenerateLibs, using gdx-jnigen's Windows ARM64 target and the LLVM-MinGWaarch64-w64-mingw32-*wrappers. The x86_64 Windows path is refactored into a sharedcreateWindowsTarget()helper and keeps its current output filename.Also:
<exception>to imgui-node-editor'scrude_json.cpp, required by the libc++ used by LLVM-MinGW;natives-windows-arm64classifiers toimgui-app;Type of change
Notes for reviewer
generateLibs -Denvs=windowsarm64 -Dlocalsucceeds; outputwindowsarm64/imgui-java64.dllhas PE machine0xAA64. The existingwindows64target still builds (0x8664).imgui-appnow carries ARM64 LWJGL natives, butbin/and the published app jar still contain only the x64 ImGui DLL; shipping/bundling the ARM64 DLL is left to the release/CI path.buildSrc/scripts/build.sh windowsarm64/ FreeType vendoring is not wired: a FreeType Windows ARM64 build needs a native autotools environment. The documented direct Gradle path builds without FreeType, like the other direct paths.