Conversation
…6.0.0 pane-registry@5.0.1)
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused fix correctly uses the existing drag helper and includes comprehensive regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Enables dragging “Everyone” directly to an ACL access level without dropping the globe icon URL.
Changes:
- Makes the button draggable as
foaf:Agent. - Disables native image dragging.
- Adds regression tests for drag-and-drop and click behavior.
| File | Description |
|---|---|
src/acl/add-agent-buttons.ts |
Configures semantic dragging for “Everyone.” |
test/unit/acl/add-agent-buttons.test.ts |
Tests URI-list, plain-text, and click workflows. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dragging the Add Everyone globe directly from the sharing chooser currently drops the SVG URL. The ACL editor then tries to load that image as an RDF access target, which can produce a GitHub Pages CORS preflight error and prevents the permission change. This matches the recent report in the solidcommunity.net channel.
Make the button draggable through the existing
makeDraggablehelper usingfoaf:Agent, and disable native dragging on its child image. Users can drop Everyone directly onto the desired access level; clicking to add Everyone as a Viewer still works. No server CORS or authentication changes are needed.Fixes #448. Fixes #419.
Validation:
https://solidos.github.io/solid-ui/src/icons/noun_98053.svg; the patched button dropshttp://xmlns.com/foaf/0.1/Agent.NODE_OPTIONS=--no-experimental-webstorage npm test -- --maxWorkers=2: 660 passed, 46 skipped, including test type checking. On this Node 25.1.0 workstation, the unmodified test command hits three login-component failures becauselocalStorage.clearis unavailable; disabling Node's experimental web storage lets jsdom provide it. CI uses Node 22/24.npm run build: passed, including source type checking, library/CDN bundles and Storybook.git diff --check: passed.