remove table structure - #763
Open
SharonStrats wants to merge 3 commits into
Open
SharonStrats wants to merge 3 commits into
SharonStrats wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The DOM migration currently breaks editing, collapse/navigation, layout, accessibility, and existing tests.
Review effort: Balanced
Findings: 1
Open (9)
What changed in this PR
Replaces the outline’s table-based DOM with block elements and provider components.
Changes:
- Migrates outline rendering and editing from table elements to DIVs.
- Extracts outline DOM helpers.
- Updates related dependencies and lockfile.
| File | Description |
|---|---|
src/outline/userInput.js |
Adapts editing to DIV statement rows. |
src/outline/outlineDomHelpers.ts |
Adds reusable outline DOM helpers. |
src/outline/manager.js |
Migrates outline rendering and navigation. |
package.json |
Updates coordinated Solid dependencies. |
package-lock.json |
Records resolved dependency updates. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Prompt: several prompts to help resolve the PR feedback because this is very detailed. Not sure if this code will stay the way it is as more will be rewritten. Co-authored-by: GPT-5.4 Mini <gpt-5.4-mini@openai.com>
SharonStrats
force-pushed
the
task/restructure
branch
from
September 27, 2026 12:33
8dd254e to
6abbc72
Compare
…@5.0.0-2 pane-registry@5.0.0-1 activitystreams-pane@2.0.0-0 chat-pane@4.0.0-0 contacts-pane@4.0.0-0 folder-pane@4.0.0-0 issue-pane@4.0.0-0 meeting-pane@4.0.0-0 profile-pane@4.0.0-0 source-pane@4.0.0-0) (latest: rdflib@2.4.1)
Member
|
This is a huge undertaking. But it looks okish to me. We need to be very careful though.. the databworser also depends on some calls |
timea-solid
requested changes
Sep 29, 2026
| expect(result).toHaveTextContent('...') | ||
| }) | ||
| }) | ||
|
|
Member
There was a problem hiding this comment.
I think you do not need this anymore
| // Add the x more <TR> here | ||
| const moreTR = dom.createElement('tr') | ||
| const moreTD = moreTR.appendChild(dom.createElement('td')) | ||
| const moreTR = dom.createElement('div') |
Member
There was a problem hiding this comment.
it is not moreTR I believe...
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First pass at removing the table. I think we still need a bit more code cleanup. I will do that as I go.