Skip to content

Write every utils::fs atomic file through one stage-and-rename core (#728) #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mikola Lysenko (mikolalysenko) merged 3 commits into from
Oct 5, 2026
Merged

Write every utils::fs atomic file through one stage-and-rename core (#728) #858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9b631e
Start refactor for #728
claude Oct 5, 2026
9275866
Share one stage-and-rename core in utils::fs
claude Oct 5, 2026
c5118ba
Merge origin/main into arch-refactor/728-stage-rename-core
Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions crates/socket-patch-core/src/api/blob_fetcher.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,10 +424,6 @@ async fn stream_cache_entry_atomic(
"cache entry path has no parent directory",
))
})?;
let stem = dest
.file_name()
.map(|n| n.to_string_lossy().into_owned())
.unwrap_or_else(|| "blob".to_string());
// The cache directory (`.socket/blobs/`, `.socket/diffs/`) is created
// here, by the first download, and nowhere earlier. A fetch that lands
// nothing (all 404, offline, every hash mismatched, every body cut
Expand All @@ -442,9 +438,7 @@ async fn stream_cache_entry_atomic(
}
created_dirs.push(dir);
}
// Leading dot keeps the stage out of editor/glob views; the uuid suffix
// keeps concurrent writers of the same entry from colliding.
let stage = parent.join(format!(".socket-dl-{}-{}", stem, uuid::Uuid::new_v4()));
let stage = crate::utils::fs::stage_path(dest, ".socket-dl-");

let result = async {
// Inside the cleanup scope: a `create_dir_all` that makes some
Expand Down
Loading
Loading