Fix store-copy fold dropping copy writes (#756, #772)

[Mikola Lysenko (mikolalysenko)]

LLM Description written by Claude Code:claude-opus-5-5

Fixes #756
Fixes #772

Summary

When a package has more than one pnpm or vlt peer-variant store copy, agent-mode apply and rollback already patch or restore every copy, but they only reported what happened to the copy the package resolved to. A run that fixed only a twin copy said already_patched / applied: 0. A rollback that restored only a twin said already_original / rolledBack: 0. Both now report what they actually did.

Root cause

apply_package_patch and rollback_package_patch each had a private copy of the store-copy fan-out and of fold_copy_result. Both folds kept only success/error state and dropped the copy's per-file records (files_patched / files_rolled_back, files_verified, applied_via). The CLI classifies events and tallies from those records, so a write that landed only in a twin was invisible. The two folds had also drifted: apply carried only the ownership advisory from a copy, rollback carried any advisory.

Change

• New patch/store_copies.rs: one fan_out (primary, then every find_store_peer_variant_copies copy for pkg:npm/ purls) and one fold over a small CopyFold trait implemented by ApplyResult and RollbackResult.
• The fold merges each copy's verify records and changed files into the result under the copy's on-disk path (<copy>/index.js), with applied_via carried for apply. A failed copy still fails the result, with the same store copy … failed to <verb> note.
• A successful apply copy's --force skips (NotFound records) are not carried, for the same reason its all-skipped note is not: they describe that copy alone (Bugbot finding, fixed in 9114533).
• One advisory rule for both directions: only the ownership advisory is carried from a successful copy. In practice rollback's success advisories were already only ownership notes, so behavior is unchanged there.
• Both private fold_copy_result functions and duplicated loops are deleted (grep -rn fold_copy_result crates/ is empty).
• CLI_CONTRACT documents the copy-qualified files[].path (and filesRolledBack / filesVerified).

No wrapper changes are needed: npm/, pypi/ and gem/ only dispatch to the binary.

Per-issue tests

Issue	Test	Without fix	With fix
#756 (apply)	patch::store_copies::regression_tests::apply_reports_a_write_to_an_unpatched_twin_copy	FAIL (files_patched is [])	pass
#756 (apply, dry run)	…::apply_dry_run_carries_an_unpatched_twin_verify_record	FAIL	pass
#756 (rollback, from the follow-up comment)	…::rollback_reports_a_restore_of_a_patched_twin_copy	FAIL (files_rolled_back is [])	pass
#756 (end-to-end through the binary, pnpm and vlt layouts)	apply test binary: in_process_npm_multicopy::apply_and_rollback_report_a_write_to_only_a_store_twin	FAIL: "applied":0,"skipped":1, event skipped / already_patched (the exact symptom in the issue)	pass: applied: 1, event applied; rollback rolledBack: 1, alreadyOriginal: 0
#772 (one fold, one advisory rule, both directions)	…::apply_over_patched_twins_stays_already_patched, …::rollback_over_original_twins_stays_already_original, …::apply_force_skip_in_a_twin_keeps_an_already_patched_primary, patch::apply::tests::store_copy_fold_carries_ownership_advisories_and_failures, patch::rollback::tests::store_copy_fold_carries_advisories_and_failures, test_rollback_package_patch_new_file_deleted_in_every_pnpm_peer_variant_copy (now also asserts that the heal is reported)	—	pass

Evidence

• CI on 9114533: 356/356 check runs complete, 350 success and 6 skipped, none failed. Bugbot's review of 9114533 found no new issues. Its one finding on fd90c89 was fixed and the thread resolved.
• cargo clippy --workspace --all-features -- -D warnings: clean.
• rustfmt --check on every touched file: clean. Running cargo fmt --all on main already reformats ~130 unrelated files, so I formatted only the touched code.
• Locally, cargo test -p socket-patch-core --all-features gives 4847 passed and 4 failed. All 4 are permission-based tests that cannot fail a write when running as root, which the sandbox does. They are in untouched files and are green in CI.
• cargo test -p socket-patch-cli --all-features --lib --bins --test apply --test rollback --test cli --test scan --test get: all green locally.

🤖 Generated with Claude Code

---

Generated by Claude Code

[Mikola Lysenko (mikolalysenko)]

BugBot review

---

Generated by Claude Code

[cursor]

Stale Bugbot comment from a previous run.

[Mikola Lysenko (mikolalysenko)]

BugBot review

---

Generated by Claude Code

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 9114533. Configure here.}

[Mikola Lysenko (mikolalysenko)]

Ready for review. Head is 9114533.

• CI: all 356 check runs finished on 9114533: 350 passed, 6 skipped, none failed. The branch is up to date with main and has no conflicts.
• Bugbot: reviewed 9114533 and found no new issues. Its one earlier finding on fd90c89 (copy-level --force skips breaking the already_patched status) was fixed in 9114533, and that thread is resolved.
• Where to look: the new patch/store_copies.rs replaces the two private fold_copy_result copies in apply.rs and rollback.rs. files[].path values in CLI JSON output are now prefixed with the store-copy path, as documented in CLI_CONTRACT.md.

---

Generated by Claude Code