Skip to content

docs: v5 waste review and repacking design (reference) - #289

Merged
Mikola Lysenko (mikolalysenko) merged 2 commits into
release/v5-prereleasefrom
v5/waste-review-reference
Sep 28, 2026
Merged

Mikola Lysenko (mikolalysenko) merged 2 commits into
release/v5-prereleasefrom
v5/waste-review-reference

Conversation

@mikolalysenko

@mikolalysenko Mikola Lysenko (mikolalysenko) commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

This PR adds the two design docs from #286 to docs/design/ as reference material. #286 is being closed without merging because its findings are now split into follow-up PRs, and this PR keeps its docs.

  • docs/design/v5-waste-review.md: the 69 ranked findings, the measurements, and the dropped findings.
  • docs/design/repacking-to-depscan.md: what each repo builds, and what moving the rest of repacking to depscan would take.

Both files match v5/waste-review (4e989ca) except for one added blockquote under the title. It links the triage map on #286, which names the workstream, in-flight PR or owner decision for each finding. git diff origin/v5/waste-review -- docs/design shows 8 insertions and nothing else.

The PR changes docs only: no code, tests or workflows.

🤖 Generated with Claude Code


Generated by Claude Code


Note

Low Risk
Documentation-only addition with no runtime or CI behavior changes.

Overview
Adds reference design docs under docs/design/ so material from closed PR #286 stays in-repo while follow-up work lands elsewhere.

v5-waste-review.md inventories socket-patch + depscan patch-system waste: 69 ranked findings (F01–F80), measurements, top-10 cuts, totals, and dropped findings. It points owners at the #286 triage map for workstream/PR assignment.

repacking-to-depscan.md records the chosen server-primary vendoring model (depscan produces patched bytes; CLI keeps a single local builder for PyPI wheels), contract v2 on POST …/patches/package, migration phases 0–5, and open owner questions. It cross-links the waste review for CI levers and finding IDs.

Both files are largely a copy of the v5/waste-review branch content; the only intentional delta vs that branch is the triage-map blockquote under each title. No code, tests, or workflows change.

Reviewed by Cursor Bugbot for commit d77c5e6. Configure here.

Keep the v5 waste review and the repacking-to-depscan design from
PR #286 as reference docs. #286 is being closed without merging, and
its findings now belong to follow-up PRs. Each doc starts with a line
that links the triage map on #286, which gives every finding's owner.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@mikolalysenko

Copy link
Copy Markdown
Collaborator Author

[agent] ready to land

This PR changes docs only: it adds 2 files under docs/design/, which are #286's docs plus one header line each. If coverage or test* go red, the cause is the base, not this PR. The base release/v5-prerelease has the known F77 failure (e2e_redirect_cargo_build.rs case (3)), which W0 / #288 fixes.


Generated by Claude Code

@mikolalysenko

Copy link
Copy Markdown
Collaborator Author

[agent] CI note: test (windows-latest) is red, and the cause is the base, not this PR.


Generated by Claude Code

@mikolalysenko

Copy link
Copy Markdown
Collaborator Author

#283 landed on release/v5-prerelease as 06437d2; please merge origin/release/v5-prerelease again, resolve conflicts, get green, and keep it ready.


Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@mikolalysenko
Mikola Lysenko (mikolalysenko) merged commit 388eea3 into release/v5-prerelease Sep 28, 2026
84 of 85 checks passed
@mikolalysenko
Mikola Lysenko (mikolalysenko) deleted the v5/waste-review-reference branch September 28, 2026 16:36
Mikola Lysenko (mikolalysenko) pushed a commit that referenced this pull request Sep 28, 2026
…etup-and-ui

Take the base's configuration.md deferred-defaults paragraph, which
already accounts for `setup` being removed in v5.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PQaKzoW5dSw9u5pgAAvVRj
Mikola Lysenko (mikolalysenko) pushed a commit that referenced this pull request Sep 28, 2026
…ed-engine

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KHZ8uzdXfkG2zH8ZYDG8ju
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants