Repository navigation
fix(prettier-plugin-liquid): support Jinja prettier-ignore comments - #1341
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
Support Jinja
{# prettier-ignore #}comments by recognising them as ignore directives and preserving the comment and following Liquid node verbatim. The regression test failed before the fix and passes with it. Verified with the plugin suite under Prettier 2 and 3 (144 tests each), type-check, build, formatting check and targeted idempotence test. Fixes #1236.What's next? Any followup issues?
No follow-up work identified.
What did you learn?
The Liquid parser keeps Jinja comments as text nodes, so the ignore check needs to recognise the comment in that form.
Tophatting
Before you deploy
changeset