Repository navigation
Fix relation ids generation for composite primary keys - #2724
Merged
Merged
Conversation
Use the column helper’s composite-aware id path so RBI generation accepts an array primary key and returns typed tuples. Cover composite and nonstandard scalar keys in the Relations compiler specs. Pax-Session: interactive:terminal/01a0e468-c6cd-7049-8a4c-01fc37048a82 Pax-Origin: interactive:terminal Co-authored-by: Pax <262454628+hey-pax@users.noreply.github.com>
Contributor
Author
|
I have signed the CLA! |
paracycle
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ActiveRecordRelationspassesprimary_keytoActiveRecordColumnTypeHelper#type_forwhile generatingids. For a composite primary key, that value is an Array, buttype_foraccepts a String, so DSL RBI generation raises aTypeErrorinstead of producing relation methods.Fixes #2723.
Implementation
Ask the helper for
"id", which already delegates to its composite-awareid_typeimplementation. Scalar models still resolve their actual primary-key column, including nonstandard names. The existing compositefindsignatures are unchanged.Tests
Added an SQLite-backed compiler regression with a three-column String/Date/Date primary key. It failed before the fix with
Expected type ::String, got type Arrayand passes withidsreturningT::Array[[::String, ::Date, ::Date]]. Added coverage for a nonstandard scalar primary key.