Repository navigation
fix: preserve dependency order and resource ownership in experiment execution - #342
Open
Cookie0103 wants to merge 1 commit into
Open
Cookie0103 wants to merge 1 commit into
Cookie0103 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dependency-ordered study can currently run children before parents in the sequential backend, submit part of an invalid Ray graph, and associate Ray results with the wrong experiment when references finish out of order. Shared agent resources can also be prepared repeatedly or left open after partial preparation and cleanup failures.
This repairs the experiment execution lifecycle across graph validation, dispatch, monitoring, and resource cleanup:
Validation on the frozen lock (Python 3.12.13, Ray 2.48.0, pytest 7.3.2): 133 passed, 1 skipped, 6 deselected in the experiment suite. The 120 new cases cover deterministic failure regressions, native ExpArgs persistence/relaunch, and real local Ray execution, including failed-parent isolation and per-episode deadlines. The independent review rerun passed all 112 deterministic cases. Black 25.1.0, darglint, compileall, and diff checks pass.
Browser/provider-dependent tests were excluded; no real LLM or remote benchmark was exercised. Ray runtime deadlines still depend on task-state availability; sequential/joblib deadlines remain unenforced. These limitations and the changed joblib/shared-agent behavior are documented.
Prepared with AI assistance.