Repository navigation
클래스 Feature의 역할별 Interface 의존성 적용 - #75
Conversation
Class Feature의 단일 classUseCase 참조를 화면 역할에 맞는 Interface 의존성으로 분리합니다. 참여와 추천 화면은 필요한 두 Interface만 주입하고 리포트 미리보기도 결과 Interface에 맞춥니다.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
제출하신 PR은 |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b57bf9c3b5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @Dependency(\.classRoomUseCase) private var classRoomUseCase | ||
| @Dependency(\.classMemberUseCase) private var classMemberUseCase |
There was a problem hiding this comment.
The existing test and audit callers still inject classUseCase, which is independent of classRoomUseCase, so these reducers now silently use the default MockClassRepository instead of the supplied stub. For example, ClassDeadlineEditTests.저장_실패는_폼을_남겨_수동_재시도할_수_있다 injects an empty repository to force .invalidCode, but the new key resolves to a populated repository; ClassJoinTests and MyClassTests likewise lose their configured responses and shared repository state. Update the affected test and audit overrides alongside this migration so the existing assertions and coordinator/child state sharing remain valid.
Useful? React with 👍 / 👎.
변경 내용
classUseCase의존성을 역할별 Interface 키로 교체했습니다.확인
xcodebuild -workspace Picke.xcworkspace -scheme Class -configuration Debug -destination 'generic/platform=iOS Simulator' -derivedDataPath Tuist/.build/class-interface-derived CODE_SIGNING_ALLOWED=NO build -quiet성공git diff --check통과classUseCase주입 14곳은 후속 확인이 필요합니다.