Repository navigation
클래스 참여 화면을 Figma 코드 입력 시안에 맞춤 #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
1c12965
ed681b6
7836971
980b980
227a9c4
b12654c
af48560
8977b95
c3ce896
6372dc1
9fbd4c8
180bf62
7e5c7de
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -114,7 +114,6 @@ public struct ClassCoordinatorView: View { | |
| } | ||
| } | ||
| } | ||
| .toolbar(.hidden, for: .tabBar) | ||
| } | ||
| } | ||
|
|
||
|
|
||
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,21 @@ | ||
| // | ||
| // ClassBattleInterface.swift | ||
| // ClassDomainInterface | ||
| // | ||
| // Created by Picke on 10/26/26. | ||
| // | ||
|
|
||
| import ComposableArchitecture | ||
| import Foundation | ||
|
|
||
| public protocol ClassBattleInterface: Sendable { | ||
| func fetchBattle(classID: Int) async throws -> ClassBattleSession | ||
| func submitPreVote( | ||
| classID: Int, | ||
| optionID: Int | ||
| ) async throws -> ClassVoteReceipt | ||
| func submitPreVote(classID: Int, optionID: Int) async throws -> ClassVoteReceipt | ||
| func completeTTS(classID: Int) async throws | ||
| func submitPostVote( | ||
| classID: Int, | ||
| optionID: Int | ||
| ) async throws -> ClassVoteReceipt | ||
| func submitPostVote(classID: Int, optionID: Int) async throws -> ClassVoteReceipt | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔵 [P4] Readability 함수 인자 라벨이 한 줄로 정리되어 Swift API Design Guideline에 부합하게 변경되었습니다. 잘하셨습니다. |
||
| func fetchMyVotes(classID: Int) async throws -> ClassVoteHistory | ||
| func fetchVoteStats(classID: Int) async throws -> ClassVoteStats | ||
| func publishPerspective( | ||
| classID: Int, | ||
| content: String | ||
| ) async throws -> ClassPerspectiveReceipt | ||
| func publishPerspective(classID: Int, content: String) async throws -> ClassPerspectiveReceipt | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔵 [P4] Readability 함수 인자 라벨이 한 줄로 정리되어 Swift API Design Guideline에 부합하게 변경되었습니다. 잘하셨습니다. |
||
| func fetchPerspectives( | ||
| classID: Int, | ||
| cursor: String?, | ||
|
|
@@ -29,11 +27,15 @@ public protocol ClassBattleInterface: Sendable { | |
| } | ||
|
|
||
| public enum ClassBattleRepositoryDependency: TestDependencyKey { | ||
| public static var testValue: any ClassBattleInterface { UnavailableClassBattleRepository() } | ||
| public static var testValue: any ClassBattleInterface { | ||
| MockClassRepository() | ||
| } | ||
| } | ||
|
|
||
| public enum ClassBattleUseCaseDependency: TestDependencyKey { | ||
| public static var testValue: any ClassBattleInterface { UnavailableClassBattleRepository() } | ||
| public static var testValue: any ClassBattleInterface { | ||
| MockClassRepository() | ||
| } | ||
| } | ||
|
|
||
| public extension DependencyValues { | ||
|
|
||
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔵 [P4] Readability
함수 인자 라벨이 한 줄로 정리되어 Swift API Design Guideline에 부합하게 변경되었습니다. 잘하셨습니다.