Pseudo-evolution for all SO definitions - #237
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When computing the flow rates we account for "pseudo-evolution" (the fact that
\rho_{crit}evolves, which makes the SO radius evolve). There was a bug (thanks to Ruby for finding) where we always used thez=0value of the Hubble parameter in this calculation, which was incorrect. The current derivation of the pseudo-evolution term is only valid forR200c.This PR switches to a slightly different derivation of the pseudo-evolution term. It is now valid for all spherical overdensity definitions we compute in SOAP. The correct version of the Hubble parameter is now used.
Note that we don't add the Hubble flow to the particle velocities when determining if they are inflowing or outflowing. I don't think this is correct, but it seems to be the convention for the project that are studying inflows/outflows (including people who compute the flow rates themselves).