Conversation
Signed-off-by: Vamsi-klu <nrvamsi13@gmail.com>
Author
|
@treysp @izeigerman — could you review this? It touches console evaluation progress and scheduler batch lifecycle paths you have substantial recent ownership of. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Print a durable
Runningrow when each model evaluation batch starts, using the same aligned batch, model, interval, and status columns as completion output. This keeps long-running batches visible in CI, cron, and other captured logs.The change adds a backward-compatible per-batch console hook, preserves existing console implementations and audit-only behavior, and reports terminal
Failedand zero-duration states correctly.Fixes #5904
Test Plan
make fast-test.venv/bin/pytest -q tests/core/test_console.py tests/core/test_scheduler.py— 37 passed.venv/bin/pytest -q tests/cli/test_cli.py::test_run_dev— 2 passedChecklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO