Skip to content

fix(vscode): honor VS Code global telemetry setting - #6101

Open
Vamsi-klu wants to merge 1 commit into
SQLMesh:mainfrom
Vamsi-klu:fix/5690-honor-vscode-telemetry
Open

Vamsi-klu wants to merge 1 commit into
SQLMesh:mainfrom
Vamsi-klu:fix/5690-honor-vscode-telemetry

Conversation

@Vamsi-klu

Copy link
Copy Markdown

Description

Honor VS Code's global telemetry preference in every SQLMesh process launched by the extension.

  • Force SQLMESH__DISABLE_ANONYMIZED_ANALYTICS=true when VS Code telemetry is disabled, while preserving existing SQLMesh opt-outs when it is enabled.
  • Restart the LSP when the effective telemetry preference changes, including changes during initial startup.
  • Propagate the telemetry-aware environment to the tcloud authentication subprocesses.
  • Add unit and packaged code-server coverage.

Fixes #5690

Test Plan

  • pnpm exec vitest run --maxWorkers=1 --minWorkers=1 — 30 tests passed across 6 files
  • pnpm run check-types — passed
  • pnpm exec tsc --noEmit --project tsconfig.json — passed
  • pnpm exec eslint tests/utils_code_server.ts tests/configuration.spec.ts — passed
  • pnpm exec playwright test tests/configuration.spec.ts --reporter=line — 5 passed
  • git diff --check — passed

Checklist

  • I have run make style and fixed any issues
  • I have added tests for my changes (if applicable)
  • All existing tests pass (make fast-test)
  • My commits are signed off (git commit -s) per the DCO

Signed-off-by: Vamsi-klu <nrvamsi13@gmail.com>
@Vamsi-klu

Copy link
Copy Markdown
Author

@cmgoffena13 @tripleaceme — could you review this? It touches LSP startup, configuration listeners, and packaged configuration E2E coverage related to your recent work in these areas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extension does not honor VS Code global telemetry settings

1 participant