Conversation
Signed-off-by: Vamsi-klu <nrvamsi13@gmail.com>
Author
|
@benfdking @georgesittas — could you review this? It touches the VS Code subprocess helper and E2E utilities you have previously worked on and reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6093.
execFile(command, args)so executable paths and arguments containing spaces are passed intact.ExecResultbehavior for nonzero exits and spawn failures while continuing to reject cancellation withAbortError.uvtest-helper arguments separately and add regression coverage for spaced paths, literal shell metacharacters, trace output, failures, and cancellation.Test Plan
pnpm run test:unit— 26 passed, including direct executable and argument coverage under paths containing spacespnpm exec eslint src/utilities/exec.ts src/utilities/exec.test.ts tests/utils.ts— passedpnpm run check-types— passednode esbuild.js— extension bundle passedpnpm run vscode:package— VSIX packaging passedpnpm exec playwright test tests/diagnostics.spec.ts— 10 passed in 1.2mChecklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO