Skip to content

[FPSD-420, FPSD-421] Fillout banner colors - #8

Merged
jackieyoungsfgov merged 3 commits into
mainfrom
FPSD-420/banner-text-colors
Oct 28, 2026
Merged

jackieyoungsfgov merged 3 commits into
mainfrom
FPSD-420/banner-text-colors

Conversation

@jackieyoungsfgov

@jackieyoungsfgov jackieyoungsfgov commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Old PR: https://github.com/SFDigitalServices/forms/pull/29

  1. Update the link color to Primary blue for all the banners
  2. Avoid having red texts in the warning alert banner
  3. Also adds our Info/Warning/Critical/Success colors to their respective banners, following our designs
    (took out the title color and spacing between title and text, since our partners have been changing that themselves in fillout)
Screenshot 2026-10-23 at 5 09 45 PM
📦 Published canary version 0.2.2--canary.8.40599455452.0
https://unpkg.com/@sfgov/fillout@0.2.2--canary.8.40599455452.0/dist/theme-sfgov.css

Copy the URL above to test this release with the CSS extension.

@shawnbot shawnbot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I pointed the extension at the second page of the kitchen sink and confirmed that it works for all of the different alert styles.

One thing I'd like to try in this PR now that we have postcss: Can we nest all of the .fillout-field-alert styles under that selector instead of repeating it in the source?

.fillout-field-alert {
  .text-blue-400 {
    color: #0046c2;
  }
}

This will dramatically simplify the source, give us a single line to change if the fillout-field-alert selector ever needs to change, and enables other nice DX like folding in VS Code (without region comments).

@shawnbot shawnbot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, it looks great! I added bulleted lists to the alerts in the kitchen sink form to verify that the text color is fixed there, too.

@jackieyoungsfgov
jackieyoungsfgov merged commit 2baee0e into main Oct 28, 2026
8 checks passed
@jackieyoungsfgov
jackieyoungsfgov deleted the FPSD-420/banner-text-colors branch October 28, 2026 00:30

This branch was successfully deployed

1 active deployment
release — 4d1108eb Deployed Oct 27, 2026 by jackieyoungsfgov via release #30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants