Repository navigation
Restore deterministic Lighthouse cache hits - #31
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Random SVG mask IDs made six HTML pages change on every build, preventing Lighthouse's identical-build cache from matching. Use page-scoped counters for stable IDs, and include Chrome's version, runner OS/architecture, and the workflow in the cache key. Explicitly pass the identified Chrome binary to Lighthouse.
The only new TypeScript file is a 10-line SVG ID helper. The workflow uses
ubuntu-latest, the standard Lighthouse CLI, and the existing budgets and sampling policy.Evidence
pnpm check, build, event fixtures, and page metadata pass. A four-page local Lighthouse run passed the existing budgets with performance scores of 99/99/100/100.Merge Danger
Door: two-way
Blast Radius: caching
Changes generated SVG IDs and Lighthouse cache eligibility. The new key requires one successful audit before it can be reused.