Repository navigation
chore: bump ty to 0.0.88 and resolve new diagnostics - #417
Open
ricardosrib wants to merge 1 commit into
Open
ricardosrib wants to merge 1 commit into
ricardosrib wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumps
tyfrom0.0.64to0.0.88— the half of #338 that was deliberately left out of #415 because the newer ty is significantly stricter and surfaces 19 pre-existing diagnostics that need real changes.Real fixes (behavior-preserving):
adms/_async_http.py: deprecatedasyncio.iscoroutinefunction→inspect.iscoroutinefunctiondms/model.py: removed a redundantcast(RepositoryParams, {})agentgateway/converters.py: hoisted the conditional**{...}kwargs spread into adict[str, Any]variable, so the union-valued dict is no longer type-checked againstevery keyword parameter of
StructuredTool.from_function(identical runtime behavior)Suppressions via
# ty: ignore[...](matching the existing repo convention):core/auditlog/models.py(×2): deletion events intentionally overrideattributeswith
DeletedAttribute; the invariant-list override is by designpytest.raises(TypeError)and one deliberately-invalid
Libraryassignment — intentional negative testsRelated Issue
Closes #338
Type of Change
How to Test
uvx pre-commit run --all-files→ty type checkpasses (also ruff format + ruff check)uv run pytest→ full suite green (affected modules: 1148 passed, 26 skipped locally)Breaking Changes
N/A