Skip to content

docs(contributing): add /review-pr step to self-review section - #413

Merged
cassiofariasmachado merged 1 commit into
mainfrom
docs/review-pr-contributing
Oct 19, 2026
Merged

cassiofariasmachado merged 1 commit into
mainfrom
docs/review-pr-contributing

Conversation

@cassiofariasmachado

Copy link
Copy Markdown
Member

Disclaimer: Do not include SAP-internal or customer-specific information in this PR (e.g. internal system URLs, customer names, tenant IDs, or confidential configurations). This is a public repository.

Description

Adds a Local review step to the "Self-review before opening the PR" section in CONTRIBUTING.md, pointing contributors to run /review-pr in Claude Code and address all ❌ findings before submitting.

Related Issue

N/A

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Dependency update

How to Test

  1. Open CONTRIBUTING.md and navigate to section 5 "Self-review before opening the PR"
  2. Verify the Local review bullet appears as the first item in the checklist

Checklist

  • I have read the Contributing Guidelines
  • I have verified that my changes solve the issue
  • I have added/updated automated tests to cover my changes
  • All tests pass locally
  • I have verified that my code follows the Code Guidelines
  • I have updated documentation (if applicable)
  • I have added type hints for all public APIs
  • My code does not contain sensitive information (credentials, tokens, etc.)
  • I have followed Conventional Commits for commit messages

@cassiofariasmachado
cassiofariasmachado requested a review from a team as a code owner October 19, 2026 15:54
@cassiofariasmachado
cassiofariasmachado merged commit 0a78dc9 into main Oct 19, 2026
12 of 13 checks passed
@cassiofariasmachado
cassiofariasmachado deleted the docs/review-pr-contributing branch October 19, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants