Conversation
Member
|
Could you please add a description so we have some context? |
OpenRC is an alternative init system to systemd, available on Gentoo,
Alpine and many other distros (including BSDs).
What this script does:
- check that /etc/rsyncd.conf exists
- run `/usr/bin/rsync --daemon ${OPTS} --no-detach` with `NO_NEW_PRIVS`
- after the system configured network service has started
Author
done, hope this is enough? |
Member
|
OpenRC services are already maintained by the distributions which install them and this file is not integrated with our installation or release packaging. It also hard-codes Linux-specific and distribution-specific assumptions despite claiming broader portability. I do not believe rsync should maintain another unused service definition here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
packaging: add OpenRC service
OpenRC is an alternative init system to systemd, available on Gentoo,
Alpine and many other distros (including BSDs).
What this script does:
/usr/bin/rsync --daemon ${OPTS} --no-detachwithNO_NEW_PRIVSThe user can configure rsync by editing the config file.