Repository navigation
Add Playstation 2 ram notes to console-specific tips doc - #458
Merged
Merged
Conversation
Contributor
 [Low impact] The change is limited to guidance for people working with PlayStation 2 memory. Safe to merge, with a non-blocking suggestion to clarify pointer size. SummaryAdds PS2 RAM ranges and pointer-mask guidance.
Reviews (1) · Last reviewed commit: "Add Playstation 2 ram notes to console-s..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
|
||
| PlayStation 2 physical RAM is addressed at `0x00000000-0x01ffffff`, which matches the mapping RA uses. You do not usually need to mask or do any tricks to adapt pointers. Just use them straight with `Add Address`. | ||
|
|
||
| However, the system also has an uncached alias for its physical RAM addressed at `0x20000000–0x21FFFFFF` which mirrors this physical RAM. You may rarely find a game that needs to use such a pointer. When using them, mask them with 0x01ffffff: `Add Address Mem MyPointer & 0x01ffffff`. |
Contributor
There was a problem hiding this comment.
The example omits its read size. PS2's 32MB range needs 25 address bits. A 24-bit read sends pointers targeting 0x01000000 or higher to the wrong address; the mask cannot recover the lost bit.
Suggestion: Specify 32-bit in the example, as the adjacent PSP section does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://discord.com/channels/310192285306454017/962817919698501702/1568245575290331308