Skip to content

RG-T105 Updating map styles - #541

Merged
ucswift merged 1 commit into
masterfrom
develop
Oct 3, 2026
Merged

ucswift merged 1 commit into
masterfrom
develop

Conversation

@ucswift

@ucswift ucswift commented Oct 3, 2026 •

Copy link
Copy Markdown
Member

Summary

Adds support for Mapbox gallery community map styles in department mapping settings, including localized labels, grouped selection lists, style URL resolution, and dark-mode behavior.

Changes

  • Added 20 Mapbox community styles, including Blueprint, Frank, Moonlight, North Star, and Unicorn.
  • Added Mapbox gallery style URLs and model enum values for each community style.
  • Separated selectable styles into:
    • Mapbox-maintained base maps
    • Community styles
  • Updated the department mapping settings UI to display both groups separately for day and night styles.
  • Added localized group labels, style names, and guidance about reviewing community style previews before using them for dispatch in supported languages.
  • Updated automatic night-style resolution so community styles remain unchanged instead of switching to a different dark style.
  • Updated style URL resolution and validation to support both mapbox and mapbox-map-design style namespaces.
  • Expanded unit tests to cover community style parsing, grouping, URL mappings, and invalid values.
  • Updated Admin Assist and settings documentation to describe the expanded style catalog and community-style night behavior.

@Resgrid-Bot

Resgrid-Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Validate Business Logic: Ask Kody to validate your code against business rules by adding a comment with the @kody -v business-logic command.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ❌
Security ✅
Business Logic ❌

Access your configuration settings here.

​

@request-info

request-info Bot commented Oct 3, 2026

Copy link
Copy Markdown

Thanks for opening this, but we'd appreciate a little more information. Could you update it with more details?

@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: Resgrid/Core/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: a8559dc9-8c13-4518-af25-e30252c39fdd
📥 Commits

Reviewing files that changed from the base of the PR and between 86c56e7 and cf7fd49.

⛔ Files ignored due to path filters (14)
  • Core/Resgrid.AdminAssist/Catalog/mapping.yaml is excluded by !**/*.yaml
  • Core/Resgrid.Localization/Areas/User/Department/Department.ar.resx is excluded by !**/*.resx
  • Core/Resgrid.Localization/Areas/User/Department/Department.de.resx is excluded by !**/*.resx
  • Core/Resgrid.Localization/Areas/User/Department/Department.el.resx is excluded by !**/*.resx
  • Core/Resgrid.Localization/Areas/User/Department/Department.en.resx is excluded by !**/*.resx
  • Core/Resgrid.Localization/Areas/User/Department/Department.es.resx is excluded by !**/*.resx
  • Core/Resgrid.Localization/Areas/User/Department/Department.fr.resx is excluded by !**/*.resx
  • Core/Resgrid.Localization/Areas/User/Department/Department.it.resx is excluded by !**/*.resx
  • Core/Resgrid.Localization/Areas/User/Department/Department.pl.resx is excluded by !**/*.resx
  • Core/Resgrid.Localization/Areas/User/Department/Department.resx is excluded by !**/*.resx
  • Core/Resgrid.Localization/Areas/User/Department/Department.sv.resx is excluded by !**/*.resx
  • Core/Resgrid.Localization/Areas/User/Department/Department.uk.resx is excluded by !**/*.resx
  • Tests/Resgrid.Tests/Services/MapStylePresetsTests.cs is excluded by !**/Tests/**
  • docs/admin-assist/settings-reference.md is excluded by !**/*.md
📒 Files selected for processing (3)
  • Core/Resgrid.Model/MapStylePresets.cs
  • Core/Resgrid.Model/MapStyleTypes.cs
  • Web/Resgrid.Web/Areas/User/Views/Department/MappingSettings.cshtml

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC.


📝 Walkthrough

Walkthrough

The map style catalog now includes Mapbox Community Gallery styles and their URLs. The settings page separates Mapbox and community options in the day and night selectors. Community styles resolve to their mapped URLs and remain unchanged when night style is set to Automatic.

Changes

Community Map Styles

Layer / File(s) Summary
Style catalog and community mappings
Core/Resgrid.Model/MapStyleTypes.cs, Core/Resgrid.Model/MapStylePresets.cs
MapStyleTypes adds 20 community style values. MapStylePresets separates Mapbox styles from community styles, adds community URL mappings, and exposes a combined selectable list and IsCommunityStyle.
Community style resolution
Core/Resgrid.Model/MapStylePresets.cs
GetStyleUrl returns a mapped community URL before checking built-in styles. Automatic night style leaves community styles unchanged.
Mapping settings selectors
Web/Resgrid.Web/Areas/User/Views/Department/MappingSettings.cshtml
The day and night selectors group options into Mapbox and community styles. The day selector help text adds community-style guidance.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to cf7fd

The community styles appear compatible with the inspected map paths. No identified issue prevents merging after normal checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (1 skipped: 1… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title identifies the map-style updates, which are the main change in the pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@ucswift

ucswift commented Oct 3, 2026

Copy link
Copy Markdown
Member Author

Approve

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is approved.

@ucswift
ucswift merged commit 9071da9 into master Oct 3, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants