Repository navigation
Fix VDB recommit issues, BVH node flag, improved non-clobber install - #38
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Newly allocated observer-size arrays are incorrectly released with scalar delete, and key regression paths lack coverage.
Review effort: Balanced
Findings: 1
Open (3)
What changed in this PR
Fixes VDB recommit stability, signed-zero BVH leaf detection, observer bounds safety, and shared-prefix dependency installation.
Changes:
- Embeds VDB grid state to preserve sampler references across recommits.
- Uses the BVH sign bit for reliable leaf detection.
- Improves observer bounds handling and superbuild installation ordering.
| File | Description |
|---|---|
superbuild/dependencies/package_install.cmake |
Preserves existing symlinks during package installation. |
superbuild/dependencies/dep_rkcommon.cmake |
Adds conditional TBB configure dependency. |
superbuild/dependencies/dep_embree.cmake |
Separates package manifests and adjusts install ordering. |
superbuild/CMakeLists.txt |
Enables modern ExternalProject step behavior and download targets. |
openvkl/devices/gpu/compute/vklIterateUnstructured.h |
Uses centralized BVH leaf detection. |
openvkl/devices/gpu/compute/vklComputeUnstructured.h |
Uses centralized unstructured-node classification. |
openvkl/devices/gpu/compute/vklComputeParticle.h |
Uses centralized particle BVH classification. |
openvkl/devices/cpu/volume/vdb/VdbVolumeShared.h |
Embeds stable grid and dense dispatch state. |
openvkl/devices/cpu/volume/vdb/VdbVolume.ispc |
Removes obsolete grid-pointer initialization. |
openvkl/devices/cpu/volume/vdb/VdbVolume.h |
Documents the embedded-grid relationship. |
openvkl/devices/cpu/volume/vdb/VdbVolume.cpp |
Reuses embedded grid storage across recommits. |
openvkl/devices/cpu/volume/vdb/VdbSamplerShared.h |
Removes sampler-owned dense dispatch state. |
openvkl/devices/cpu/volume/vdb/VdbSampler.ispc |
Moves dense dispatch lifetime to the volume. |
openvkl/devices/cpu/volume/vdb/VdbSampler_traverseAndSample.ih |
Reads dense dispatch from the volume. |
openvkl/devices/cpu/volume/vdb/VdbLeafAccessObserver.ih |
Bounds-checks observer writes. |
openvkl/devices/cpu/volume/vdb/VdbLeafAccessObserver.cpp |
Registers observer buffer sizes. |
openvkl/devices/cpu/volume/UnstructuredVolume.ispc |
Adopts sign-bit leaf detection. |
openvkl/devices/cpu/volume/UnstructuredVolume.ih |
Includes the shared BVH helper. |
openvkl/devices/cpu/volume/UnstructuredVolume.cpp |
Updates native BVH classification. |
openvkl/devices/cpu/volume/UnstructuredBVH.ih |
Introduces interoperable sign-bit detection. |
openvkl/devices/cpu/volume/UnstructuredBVH.h |
Handles negative-zero leaf markers in C++. |
openvkl/devices/cpu/volume/particle/ParticleVolume.cpp |
Updates particle root classification. |
openvkl/devices/cpu/observer/ObserverRegistry.ispc |
Tracks per-observer buffer lengths. |
openvkl/devices/cpu/observer/ObserverRegistry.ih |
Extends registry storage with lengths. |
openvkl/devices/cpu/observer/ObserverRegistry.h |
Extends the registry add API. |
openvkl/devices/cpu/observer/ObserverRegistry.cpp |
Forwards observer lengths to ISPC. |
openvkl/devices/cpu/iterator/UnstructuredIterator.ispc |
Uses centralized leaf detection. |
doc/api.md |
Documents observer invalidation on recommit. |
CHANGELOG.md |
Records VDB recommit and observer fixes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- recommiting VDB reallocated VDBGrid, which is referenced by samplers; VDBGrid is now embedded - fix crash when recommitting VDB increased the number of leaf nodes when an old VDB leaf node access observer was reused and not recreated; observers still become stale and need to be recreated when the VDB volumes changes, to get correct access counts - fix of-by-one error when an older observer was removed while a recent observer still stays registered
Move denseLeafSample_* from sampler to VDBVolume, thus samplers do not use stale handlers when the volume got recommited. This also prevents samplers to leak the handler arrays on their recommit.
Leftovers from SharedStruct refactor 5eeefe8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.