Repository navigation
test: move integration suite outside tests/ - #17
Merged
Merged
Conversation
Bare `pytest` (used by `rbs unit-test`) collects from the repo root and would sweep up tests/integration, a suite that requires a running container. Move it to integration/ and pin testpaths to tests/ in pyproject.toml so unit and integration runs stay isolated, then update rbs.toml's integration command to match.
Closed
Redux Build System — CI Report
Overall: ✅ 7 passed · 0 failed · 2 skipped |
Trosper3
approved these changes
Sep 19, 2026
Trosper3
left a comment
Trosper3
left a comment
There was a problem hiding this comment.
I don't see anything worth flagging. Very good design!
Good features:
I like the fact that if you forget to start the server, the error message tells you exactly what is going on
It grabs the server's address once per test run instead of re-checking it every single time.
Tests hit the actual running app over the network (like a real user would), instead of faking it in-process.
The timer being 40 sec (just past the server's 25 sec limit is nice.
The design is very scalable and designed to only cover what they intended to (no fluff)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Copilot is generating a summary...]