Repository navigation
fix(Reporter): avoid redundant effect handlers - #203
Merged
Merged
Conversation
Skip the effect handler when try_with is called without emit. Use OCaml 5.3 effect-handler syntax and raise the minimum compiler version accordingly. Add regression coverage for both reporters and test OCaml 5.3.0 and 5.4.1 in CI. Fixes #202
favonia
changed the title
favonia
requested review from
mikeshulman
and removed request for
mikeshulman
October 19, 2026 05:56
favonia
marked this pull request as draft
October 19, 2026 05:57
Describe explicit emit_diagnostic forwarding as semantically equivalent but less efficient. Remove the changelog additions from this change.
favonia
marked this pull request as ready for review
October 19, 2026 06:41
Contributor
Author
|
@mikeshulman I made some minor documentation tweaks after your approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
~emitis omitted,Reporter.try_withandStructured_reporter.try_withnow catch fatal exceptions without installing an effect handler. Explicit emit handlers retain their existing behavior. The implementation also adopts OCaml 5.3's effect-handler syntax, raising the minimum supported OCaml version from 5.2 to 5.3.Related: #202 (Option 3).