Repository navigation
Support Elixir 1.16+, drop erlexec and tesla (v0.5.0) #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
drozdzynski
wants to merge
5
commits into
master
Choose a base branch
from
claude/elixir-erlang-gha-versions-52020e
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9756970
Support Elixir 1.16+ and drop erlexec and tesla dependencies
drozdzynski d4387f6
Create tmp directory in test helper
drozdzynski 65447b9
Address downloader review feedback
drozdzynski 1bb41e3
Clean up with_output on raise and handle chunk write errors
drozdzynski 2d4e6cd
Move redirect handling to Bow.Downloader implementations
drozdzynski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| name: CI | ||
|
|
||
| on: | ||
| push: | ||
| branches: [master] | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| test: | ||
| name: Elixir ${{ matrix.elixir }} / OTP ${{ matrix.otp }} | ||
| runs-on: ubuntu-24.04 | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| # minimum supported | ||
| - elixir: "1.16" | ||
| otp: "26" | ||
| # latest | ||
| - elixir: "1.20" | ||
| otp: "28" | ||
| lint: true | ||
| env: | ||
| MIX_ENV: test | ||
| services: | ||
| postgres: | ||
| image: postgres:16-alpine | ||
| env: | ||
| POSTGRES_USER: development | ||
| POSTGRES_HOST_AUTH_METHOD: trust | ||
| ports: | ||
| - 5432:5432 | ||
| options: >- | ||
| --health-cmd pg_isready | ||
| --health-interval 5s | ||
| --health-timeout 5s | ||
| --health-retries 10 | ||
| s3: | ||
| image: adobe/s3mock | ||
| env: | ||
| COM_ADOBE_TESTING_S3MOCK_STORE_INITIAL_BUCKETS: test-bucket | ||
| ports: | ||
| - 4567:9090 | ||
| steps: | ||
| - uses: actions/checkout@v5 | ||
|
|
||
| - uses: erlef/setup-beam@v1 | ||
| with: | ||
| elixir-version: ${{ matrix.elixir }} | ||
| otp-version: ${{ matrix.otp }} | ||
|
|
||
| - uses: actions/cache@v4 | ||
| with: | ||
| path: | | ||
| deps | ||
| _build | ||
| key: ${{ runner.os }}-mix-${{ matrix.elixir }}-${{ matrix.otp }}-${{ hashFiles('mix.lock') }} | ||
| restore-keys: ${{ runner.os }}-mix-${{ matrix.elixir }}-${{ matrix.otp }}- | ||
|
|
||
| - run: mix deps.get | ||
|
|
||
| - if: matrix.lint | ||
| run: mix format --check-formatted | ||
|
|
||
| - if: matrix.lint | ||
| run: mix deps.unlock --check-unused | ||
|
|
||
| - if: matrix.lint | ||
| run: mix compile --warnings-as-errors | ||
|
|
||
| - run: mix ecto.create | ||
|
|
||
| - name: Wait for S3 mock | ||
| run: timeout 60 bash -c 'until curl -sf http://localhost:4567/ > /dev/null; do sleep 1; done' | ||
|
|
||
| - run: mix test --include ecto --include s3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| erlang 28.5.0.2 | ||
| elixir 1.19.5-otp-28 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plug tracks the original
tmp_path, nottmp_path <> target.ext, an exception after writing leaves the output behind. Someis required probably 🤔