Repository navigation
Conversation
2 of 5 tasks
eitsupi
force-pushed
the
build/oxfmt-formatting
branch
from
October 18, 2026 15:23
7eaa161 to
1c7d01d
Compare
eitsupi
changed the title
eitsupi
marked this pull request as ready for review
October 18, 2026 15:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up on #1818 and the toolchain review in #1732 by introducing a shared formatter and checking formatting in CI. After the ESLint migration, contributors had no formatting command or CI check; this PR provides both and formats the existing TypeScript sources consistently.
To keep the diff reviewable, formatting is limited to TypeScript files (
.ts,.tsx,.mts,.cts) for now. Other file types can be enabled in follow-up PRs.pnpm run format/pnpm run format:check..oxfmtrc.jsoncbetween the CLI and the already recommended Oxc editor extension. Restrict the scope to TypeScript viaignorePatterns, use four-space indentation and single quotes, and disable import and package metadata sorting. Generated output (out/,dist/) is skipped through the existing Git ignore rules.src/, 4 underhtml/) in a dedicated mechanical commit. Move oneno-control-regexsuppression comment next to the regular expression after line wrapping moved it to another line.formatCI job with Node.js 24, frozen-lockfile installation, andpnpm run format:check. Enable format on save for TypeScript and document the contributor commands.