Repository navigation
[CQT-435] Comments are included in libQASM AST - #323
Merged
Merged
Conversation
elenbaasc
changed the title
elenbaasc
changed the title
davidbakker123
approved these changes
Nov 2, 2026
davidbakker123
left a comment
davidbakker123
left a comment
Contributor
There was a problem hiding this comment.
I don't see any obvious problems, although I'm no expert on the AST/ Antler stuff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments are now kept in the syntactic and semantic ASTs.
//and/* */comments are no longer discarded. They go to ANTLR's hidden channel, so the parser and the language are unaffected.Commentstatement holds the comment text and its source location. Comments are inserted among the other statements in source order.Commentstatement holds the text plusstart_line,start_column,end_lineandend_column. Lines and columns start at 1, andend_columnis one past the last character.