Repository navigation
Conversation
ktz03
marked this pull request as ready for review
October 19, 2026 03:50
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Bug fix.
Motivation and context / Related issue
Fixes #892.
For
get_lowrank_lazytensor(Q, R, d), integer row indexing currently returns(1, m)instead of(m,), and indexing a single entry returns(1,)instead of(). This also affects the lazy plans returned bylowrank_sinkhorn.Broadcast the diagonal weights directly against the indexed factor, preserving its rank. Parameterized regressions compare shapes and values against the dense product for weighted/unweighted tensors, positive/negative integer indices, mixed indices, columns, blocks, and full matrices. Existing full-plan computations keep the same values.
How has this been tested (if it applies)
python -m pytest test/test_utils.py test/test_lowrank.py test/test_solvers.py -q: 890 passed, 4 skipped, with NumPy and PyTorch CPU.Windows 11, Python 3.12.14, NumPy 2.5.4, SciPy 1.18.1, PyTorch 2.14.1. Existing transpose/convergence warnings remain. The full repository suite, CUDA, JAX, TensorFlow, documentation build, and performance benchmarks were not run.
PR checklist