Repository navigation
Fix greedy portfolio allocation with integer prices - #766
Open
DirkEmmett wants to merge 1 commit into
Open
DirkEmmett wants to merge 1 commit into
DirkEmmett wants to merge 1 commit into
Conversation
Promote the private weight calculation buffer before normalization without changing caller prices. Cover long-only, nullable-integer, and short/reinvestment portfolios with exact allocation and budget checks.
|
I hand-checked the new tests against the code on the PR branch, without running the suite.
The One thing the tests don't cover: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
greedy_portfolio()crashes during weight normalization when quotes are stored as integer prices.Use a floating-point calculation buffer without changing the caller's price Series or allocation policy. Adds regressions for integer and nullable-integer quotes, long/short portfolios, reinvestment, and budget conservation.
Validation: 317 tests passed, 4 skipped locally (Python 3.12, NumPy 1.26.4, pandas 2.2.3, SciPy 1.15.3). Ruff passed.