Repository navigation
Conversation
The PANEL button opens controlpanel, the panel mpvst's editor uses, with an EXIT button in place of the floating BACK one. drum_seq held only a copy of the old panel, so it goes, with its manifest and gallery.toml rows.
Contributor
Author
|
Replaced by #10, rebased onto main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The drum machine's PANEL button now opens
controlpanel(PyDevices/pydevices#368), the same panel mpvst's editor uses. The machine's kits sit on backlit pads, its 16 macros on encoders with LED rings, and a dot-matrix display shows the patch and the value being turned. The panel's EXIT button returns to the sequencer, replacing the floating BACK button. The screen is deleted asynchronously, after EXIT's own click returns.drum_seqheld only a word-for-word copy of the old panel, so it goes, along withpackages/drum_seq.jsonand itsgallery.tomlrows. The cast README now names thecontrolpanelpackage where it nameddrum_seq.controlpaneljoins the generator's installable deps and the drum machine's# deps:line. The browser link asks forpydevices-controlpanel(the wheel mapping is in PyDevices/pydevices#368), and the generated pages are refreshed.Tested on CPython 3.12, Linux, at the drum machine's 720 x 480 with a TR-808 loaded:
program_change, and every encoder showed the instrument's macro values afterwards.gallery_generator.py --checkis clean.This needs PyDevices/pydevices#368 merged and
controlpanelpublished, or installed beside the example on a board, before it merges. Without it, PANEL does nothing, as before, when the import fails.Draft: the look gets a review first.