Repository navigation
rhythm909: build at sample rates below 32 kHz - #36
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bit-depth/rate crusher asked its hold for 32 kHz regardless of the output rate. On MicroPython the hold node refuses a rate above the output rate, so rhythm909 failed to create at 24000, 22050 and 16000 Hz. The hold rate is now capped at the output rate (at 24 kHz the hold passes every frame, which is what the numpy path already did). Output at 32 kHz and above is unchanged: a 48 kHz render is byte-identical before and after.
Adds a MicroPython test that builds at 22050 and 24000 and plays every pad.
Closes #35