This repository was archived by the owner on Oct 31, 2026. It is now read-only.
Repository navigation
Kit tests: import kit_claims lazily - #248
Merged
Merged
Conversation
kit_claims parses source with ast, which MicroPython and CircuitPython lack, so the module-level import broke the native kit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kit_claims reads source with ast, which only CPython has. Importing it at the top of tests/support/kit_plants.py made the native kit tests fail on MicroPython and CircuitPython. It's now imported in the CPython branch of load_plants, the only place it's used.